From 1e800d9551e889ce38d4fb0997d0c6673d5e6821 Mon Sep 17 00:00:00 2001 From: Mario Liebisch Date: Tue, 20 Mar 2018 09:33:06 +0100 Subject: [PATCH] Android: No longer keep an active input stream longer than needed. --- include/SFML/Graphics/Image.hpp | 3 --- src/SFML/Graphics/Image.cpp | 16 ++-------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/SFML/Graphics/Image.hpp b/include/SFML/Graphics/Image.hpp index c950f580..c1d672a6 100644 --- a/include/SFML/Graphics/Image.hpp +++ b/include/SFML/Graphics/Image.hpp @@ -265,9 +265,6 @@ private: //////////////////////////////////////////////////////////// Vector2u m_size; ///< Image size std::vector m_pixels; ///< Pixels of the image - #ifdef SFML_SYSTEM_ANDROID - void* m_stream; ///< Asset file streamer (if loaded from file) - #endif }; } // namespace sf diff --git a/src/SFML/Graphics/Image.cpp b/src/SFML/Graphics/Image.cpp index 7670eb6c..67c2840d 100644 --- a/src/SFML/Graphics/Image.cpp +++ b/src/SFML/Graphics/Image.cpp @@ -41,23 +41,14 @@ namespace sf Image::Image() : m_size(0, 0) { - #ifdef SFML_SYSTEM_ANDROID - m_stream = NULL; - - #endif } //////////////////////////////////////////////////////////// Image::~Image() { - #ifdef SFML_SYSTEM_ANDROID - if (m_stream) - delete (priv::ResourceStream*)m_stream; - - #endif } @@ -135,11 +126,8 @@ bool Image::loadFromFile(const std::string& filename) #else - if (m_stream) - delete (priv::ResourceStream*)m_stream; - - m_stream = new priv::ResourceStream(filename); - return loadFromStream(*(priv::ResourceStream*)m_stream); + priv::ResourceStream stream(filename); + return loadFromStream(stream); #endif }