Edgaru089/SFML
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply SFML_ prefix to compiler warning option

Browse Source
This commit is contained in:
Chris Thrasher 2023-07-16 14:14:42 -06:00
parent 00b6488c3e
commit 659eca2a62
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmake/CompilerWarnings.cmake
View File

@ -4,11 +4,11 @@
# Helper function to enable compiler warnings for a specific target # Helper function to enable compiler warnings for a specific target
function(set_target_warnings target) function(set_target_warnings target)
option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" TRUE) option(SFML_WARNINGS_AS_ERRORS "Treat compiler warnings as errors" TRUE)
if(SFML_COMPILER_MSVC) if(SFML_COMPILER_MSVC)
target_compile_options(${target} PRIVATE target_compile_options(${target} PRIVATE
$<$<BOOL:${WARNINGS_AS_ERRORS}>:/WX> $<$<BOOL:${SFML_WARNINGS_AS_ERRORS}>:/WX>
/W4 # Baseline reasonable warnings /W4 # Baseline reasonable warnings
/w14242 # 'identifier': conversion from 'type1' to 'type1', possible loss of data /w14242 # 'identifier': conversion from 'type1' to 'type1', possible loss of data
/w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data /w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data
@ -40,7 +40,7 @@ function(set_target_warnings target)
if(SFML_COMPILER_GCC OR SFML_COMPILER_CLANG) if(SFML_COMPILER_GCC OR SFML_COMPILER_CLANG)
target_compile_options(${target} PRIVATE target_compile_options(${target} PRIVATE
$<$<BOOL:${WARNINGS_AS_ERRORS}>:-Werror> $<$<BOOL:${SFML_WARNINGS_AS_ERRORS}>:-Werror>
-Wall -Wall
-Wextra # reasonable and standard -Wextra # reasonable and standard
-Wshadow # warn the user if a variable declaration shadows one from a parent context -Wshadow # warn the user if a variable declaration shadows one from a parent context