Remove unused headers and reduce physical dependencies

include/SFML/Audio/InputSoundFile.hpp

@@ -34,7 +34,6 @@
 #include <cstddef>
 #include <filesystem>
 #include <memory>
-#include <string>
 
 
 namespace sf

include/SFML/Audio/Music.hpp

@@ -33,7 +33,6 @@
 #include <SFML/Audio/SoundStream.hpp>
 
 #include <filesystem>
-#include <string>
 #include <vector>
 
 

include/SFML/Audio/OutputSoundFile.hpp

@@ -33,7 +33,6 @@
 
 #include <filesystem>
 #include <memory>
-#include <string>
 
 
 namespace sf

include/SFML/Audio/SoundFileFactory.hpp

@@ -31,7 +31,6 @@
 
 #include <filesystem>
 #include <memory>
-#include <string>
 #include <vector>
 
 

include/SFML/Audio/SoundFileWriter.hpp

@@ -30,7 +30,6 @@
 #include <SFML/Audio/Export.hpp>
 
 #include <filesystem>
-#include <string>
 
 
 namespace sf

include/SFML/Graphics/Image.hpp

@@ -33,7 +33,7 @@
 #include <SFML/Graphics/Rect.hpp>
 
 #include <filesystem>
-#include <string>
+#include <string_view>
 #include <vector>
 
 
@@ -156,7 +156,7 @@ public:
     /// \see create, loadFromFile, loadFromMemory, saveToFile
     ///
     ////////////////////////////////////////////////////////////
-    [[nodiscard]] bool saveToMemory(std::vector<std::uint8_t>& output, const std::string& format) const;
+    [[nodiscard]] bool saveToMemory(std::vector<std::uint8_t>& output, std::string_view format) const;
 
     ////////////////////////////////////////////////////////////
     /// \brief Return the size (width and height) of the image

include/SFML/Graphics/Text.hpp

@@ -35,7 +35,6 @@
 #include <SFML/Graphics/VertexArray.hpp>
 #include <SFML/System/String.hpp>
 
-#include <string>
 #include <vector>
 
 

include/SFML/System/FileInputStream.hpp

@@ -36,7 +36,6 @@
 #include <cstdio>
 #include <filesystem>
 #include <memory>
-#include <string>
 
 #ifdef SFML_SYSTEM_ANDROID
 namespace sf::priv

include/SFML/System/String.hpp

@@ -31,7 +31,6 @@
 
 #include <SFML/System/Utf.hpp>
 
-#include <iterator>
 #include <locale>
 #include <string>
 

include/SFML/System/Utf.hpp

@@ -30,9 +30,7 @@
 #include <SFML/Config.hpp>
 
 #include <cstdlib>
-#include <iterator>
 #include <locale>
-#include <string>
 
 
 namespace sf

src/SFML/Audio/SoundFileWriterWav.hpp

@@ -29,8 +29,8 @@
 ////////////////////////////////////////////////////////////
 #include <SFML/Audio/SoundFileWriter.hpp>
 
+#include <filesystem>
 #include <fstream>
-#include <string>
 
 
 namespace sf::priv

src/SFML/Graphics/Image.cpp

@@ -138,9 +138,9 @@ bool Image::saveToFile(const std::filesystem::path& filename) const
 }
 
 ////////////////////////////////////////////////////////////
-bool Image::saveToMemory(std::vector<std::uint8_t>& output, const std::string& format) const
+bool Image::saveToMemory(std::vector<std::uint8_t>& output, std::string_view format) const
 {
-    return priv::ImageLoader::getInstance().saveImageToMemory(format, output, m_pixels, m_size);
+    return priv::ImageLoader::getInstance().saveImageToMemory(std::string(format), output, m_pixels, m_size);
 }
 
 

src/SFML/Window/DRM/ClipboardImpl.cpp

@@ -25,9 +25,9 @@
 ////////////////////////////////////////////////////////////
 // Headers
 ////////////////////////////////////////////////////////////
+#include <SFML/System/String.hpp>
 #include <SFML/Window/DRM/ClipboardImpl.hpp>
 
-
 namespace sf::priv
 {
 ////////////////////////////////////////////////////////////

src/SFML/Window/DRM/ClipboardImpl.hpp

@@ -24,13 +24,11 @@
 
 #pragma once
 
-////////////////////////////////////////////////////////////
+namespace sf
-// Headers
+{
-////////////////////////////////////////////////////////////
+class String;
-#include <SFML/System/String.hpp>
 
-
+namespace priv
-namespace sf::priv
 {
 ////////////////////////////////////////////////////////////
 /// \brief Give access to the system clipboard
@@ -64,4 +62,5 @@ public:
     static void setString(const String& text);
 };
 
-} // namespace sf::priv
+} // namespace priv
+} // namespace sf

src/SFML/Window/Win32/VulkanImplWin32.cpp

@@ -29,7 +29,7 @@
 #include <SFML/Window/Win32/VulkanImplWin32.hpp>
 
 #include <map>
-#include <string>
+#include <string_view>
 #define VK_USE_PLATFORM_WIN32_KHR
 #define VK_NO_PROTOTYPES
 #include <vulkan.h>