Edgaru089/SFML
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't reimplement std::copy().

Browse Source 
Using std::copy() potentially makes available helpful checks in debug mode and
can also lead to faster code by calling memcpy() in release mode.
The <algorithm> header was already included.
This commit is contained in:
Christian Neumüller 2013-06-24 00:49:40 +02:00
parent 99d4ec3551
commit 891e9de0fe
1 changed files with 7 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
include/SFML/System/Utf.inl
View File

@ -104,7 +104,7 @@ Out Utf<8>::encode(Uint32 input, Out output, Uint8 replacement)
// Valid character
// Get the number of bytes to write
int bytestoWrite = 1;
std::size_t bytestoWrite = 1;
if (input < 0x80) bytestoWrite = 1;
else if (input < 0x800) bytestoWrite = 2;
else if (input < 0x10000) bytestoWrite = 3;
@ -121,14 +121,7 @@ Out Utf<8>::encode(Uint32 input, Out output, Uint8 replacement)
}
// Add them to the output
const Uint8* currentByte = bytes;
switch (bytestoWrite)
{
case 4 : *output++ = *currentByte++;
case 3 : *output++ = *currentByte++;
case 2 : *output++ = *currentByte++;
case 1 : *output++ = *currentByte++;
}
output = std::copy(bytes, bytes + bytestoWrite, output);
}
return output;
@ -251,10 +244,7 @@ Out Utf<8>::toLatin1(In begin, In end, Out output, char replacement)
template <typename In, typename Out>
Out Utf<8>::toUtf8(In begin, In end, Out output)
{
while (begin < end)
*output++ = *begin++;
return output;
return std::copy(begin, end, output);
}
@ -423,10 +413,7 @@ Out Utf<16>::fromLatin1(In begin, In end, Out output)
{
// Latin-1 is directly compatible with Unicode encodings,
// and can thus be treated as (a sub-range of) UTF-32
while (begin < end)
*output++ = *begin++;
return output;
return std::copy(begin, end, output);
}
@ -495,10 +482,7 @@ Out Utf<16>::toUtf8(In begin, In end, Out output)
template <typename In, typename Out>
Out Utf<16>::toUtf16(In begin, In end, Out output)
{
while (begin < end)
*output++ = *begin++;
return output;
return std::copy(begin, end, output);
}
@ -579,10 +563,7 @@ Out Utf<32>::fromLatin1(In begin, In end, Out output)
{
// Latin-1 is directly compatible with Unicode encodings,
// and can thus be treated as (a sub-range of) UTF-32
while (begin < end)
*output++ = *begin++;
return output;
return std::copy(begin, end, output);
}
@ -649,10 +630,7 @@ Out Utf<32>::toUtf16(In begin, In end, Out output)
template <typename In, typename Out>
Out Utf<32>::toUtf32(In begin, In end, Out output)
{
while (begin < end)
*output++ = *begin++;
return output;
return std::copy(begin, end, output);
}