Edgaru089/SFML
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Assert that a video mode exists before trying to use it

Browse Source 
This converts a segfault into a more predictable failure, at least
in debug builds.
This commit is contained in:
Chris Thrasher 2023-06-16 16:09:34 -06:00
parent a0c10b8dfb
commit a8e901e754
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/SFML/Window/Window.cpp
View File

@ -34,6 +34,8 @@
#include <ostream> #include <ostream>
#include <cassert>
namespace sf namespace sf
{ {
@ -90,6 +92,7 @@ void Window::create(VideoMode mode, const String& title, std::uint32_t style, co
if (!mode.isValid()) if (!mode.isValid())
{ {
err() << "The requested video mode is not available, switching to a valid mode" << std::endl; err() << "The requested video mode is not available, switching to a valid mode" << std::endl;
assert(!VideoMode::getFullscreenModes().empty() && "No video modes available");
mode = VideoMode::getFullscreenModes()[0]; mode = VideoMode::getFullscreenModes()[0];
} }