Renamed SoundStream::Chunk::NbSamples to SampleCount, and renamed other nbSamples variables to sampleCount

This commit is contained in:
Laurent Gomila 2012-01-13 15:09:30 +01:00
parent c2039e866c
commit e775bd0169
7 changed files with 39 additions and 39 deletions

View File

@ -89,7 +89,7 @@ private :
// Fill audio data to pass to the stream // Fill audio data to pass to the stream
data.Samples = &myTempBuffer[0]; data.Samples = &myTempBuffer[0];
data.NbSamples = myTempBuffer.size(); data.SampleCount = myTempBuffer.size();
// Update the playing offset // Update the playing offset
myOffset += myTempBuffer.size(); myOffset += myTempBuffer.size();
@ -127,13 +127,13 @@ private :
{ {
// Extract audio samples from the packet, and append it to our samples buffer // Extract audio samples from the packet, and append it to our samples buffer
const sf::Int16* samples = reinterpret_cast<const sf::Int16*>(packet.GetData() + 1); const sf::Int16* samples = reinterpret_cast<const sf::Int16*>(packet.GetData() + 1);
std::size_t nbSamples = (packet.GetDataSize() - 1) / sizeof(sf::Int16); std::size_t sampleCount = (packet.GetDataSize() - 1) / sizeof(sf::Int16);
// Don't forget that the other thread can access the sample array at any time // Don't forget that the other thread can access the sample array at any time
// (so we protect any operation on it with the mutex) // (so we protect any operation on it with the mutex)
{ {
sf::Lock lock(myMutex); sf::Lock lock(myMutex);
std::copy(samples, samples + nbSamples, std::back_inserter(mySamples)); std::copy(samples, samples + sampleCount, std::back_inserter(mySamples));
} }
} }
else if (id == endOfStream) else if (id == endOfStream)

View File

@ -50,7 +50,7 @@ public :
struct Chunk struct Chunk
{ {
const Int16* Samples; ///< Pointer to the audio samples const Int16* Samples; ///< Pointer to the audio samples
std::size_t NbSamples; ///< Number of samples pointed by Samples std::size_t SampleCount; ///< Number of samples pointed by Samples
}; };
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
@ -351,7 +351,7 @@ private :
/// { /// {
/// // Fill the chunk with audio data from the stream source /// // Fill the chunk with audio data from the stream source
/// data.Samples = ...; /// data.Samples = ...;
/// data.NbSamples = ...; /// data.SampleCount = ...;
/// ///
/// // Return true to continue playing /// // Return true to continue playing
/// return true; /// return true;

View File

@ -119,10 +119,10 @@ bool Music::OnGetData(SoundStream::Chunk& data)
// Fill the chunk parameters // Fill the chunk parameters
data.Samples = &mySamples[0]; data.Samples = &mySamples[0];
data.NbSamples = myFile->Read(&mySamples[0], mySamples.size()); data.SampleCount = myFile->Read(&mySamples[0], mySamples.size());
// Check if we have reached the end of the audio file // Check if we have reached the end of the audio file
return data.NbSamples == mySamples.size(); return data.SampleCount == mySamples.size();
} }

View File

@ -213,13 +213,13 @@ SoundBuffer& SoundBuffer::operator =(const SoundBuffer& right)
bool SoundBuffer::Initialize(priv::SoundFile& file) bool SoundBuffer::Initialize(priv::SoundFile& file)
{ {
// Retrieve the sound parameters // Retrieve the sound parameters
std::size_t nbSamples = file.GetSampleCount(); std::size_t sampleCount = file.GetSampleCount();
unsigned int channelCount = file.GetChannelCount(); unsigned int channelCount = file.GetChannelCount();
unsigned int sampleRate = file.GetSampleRate(); unsigned int sampleRate = file.GetSampleRate();
// Read the samples from the provided file // Read the samples from the provided file
mySamples.resize(nbSamples); mySamples.resize(sampleCount);
if (file.Read(&mySamples[0], nbSamples) == nbSamples) if (file.Read(&mySamples[0], sampleCount) == sampleCount)
{ {
// Update the internal buffer with the new samples // Update the internal buffer with the new samples
return Update(channelCount, sampleRate); return Update(channelCount, sampleRate);

View File

@ -54,7 +54,7 @@ namespace priv
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
SoundFile::SoundFile() : SoundFile::SoundFile() :
myFile (NULL), myFile (NULL),
myNbSamples (0), mySampleCount (0),
myChannelCount(0), myChannelCount(0),
mySampleRate (0) mySampleRate (0)
{ {
@ -73,7 +73,7 @@ SoundFile::~SoundFile()
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
std::size_t SoundFile::GetSampleCount() const std::size_t SoundFile::GetSampleCount() const
{ {
return myNbSamples; return mySampleCount;
} }
@ -110,7 +110,7 @@ bool SoundFile::OpenRead(const std::string& filename)
// Set the sound parameters // Set the sound parameters
myChannelCount = fileInfos.channels; myChannelCount = fileInfos.channels;
mySampleRate = fileInfos.samplerate; mySampleRate = fileInfos.samplerate;
myNbSamples = static_cast<std::size_t>(fileInfos.frames) * myChannelCount; mySampleCount = static_cast<std::size_t>(fileInfos.frames) * myChannelCount;
return true; return true;
} }
@ -147,7 +147,7 @@ bool SoundFile::OpenRead(const void* data, std::size_t sizeInBytes)
// Set the sound parameters // Set the sound parameters
myChannelCount = fileInfos.channels; myChannelCount = fileInfos.channels;
mySampleRate = fileInfos.samplerate; mySampleRate = fileInfos.samplerate;
myNbSamples = static_cast<std::size_t>(fileInfos.frames) * myChannelCount; mySampleCount = static_cast<std::size_t>(fileInfos.frames) * myChannelCount;
return true; return true;
} }
@ -179,7 +179,7 @@ bool SoundFile::OpenRead(InputStream& stream)
// Set the sound parameters // Set the sound parameters
myChannelCount = fileInfos.channels; myChannelCount = fileInfos.channels;
mySampleRate = fileInfos.samplerate; mySampleRate = fileInfos.samplerate;
myNbSamples = static_cast<std::size_t>(fileInfos.frames) * myChannelCount; mySampleCount = static_cast<std::size_t>(fileInfos.frames) * myChannelCount;
return true; return true;
} }
@ -218,35 +218,35 @@ bool SoundFile::OpenWrite(const std::string& filename, unsigned int channelCount
// Set the sound parameters // Set the sound parameters
myChannelCount = channelCount; myChannelCount = channelCount;
mySampleRate = sampleRate; mySampleRate = sampleRate;
myNbSamples = 0; mySampleCount = 0;
return true; return true;
} }
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
std::size_t SoundFile::Read(Int16* data, std::size_t nbSamples) std::size_t SoundFile::Read(Int16* data, std::size_t sampleCount)
{ {
if (myFile && data && nbSamples) if (myFile && data && sampleCount)
return static_cast<std::size_t>(sf_read_short(myFile, data, nbSamples)); return static_cast<std::size_t>(sf_read_short(myFile, data, sampleCount));
else else
return 0; return 0;
} }
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
void SoundFile::Write(const Int16* data, std::size_t nbSamples) void SoundFile::Write(const Int16* data, std::size_t sampleCount)
{ {
if (myFile && data && nbSamples) if (myFile && data && sampleCount)
{ {
// Write small chunks instead of everything at once, // Write small chunks instead of everything at once,
// to avoid a stack overflow in libsndfile (happens only with OGG format) // to avoid a stack overflow in libsndfile (happens only with OGG format)
while (nbSamples > 0) while (sampleCount > 0)
{ {
std::size_t count = nbSamples > 10000 ? 10000 : nbSamples; std::size_t count = sampleCount > 10000 ? 10000 : sampleCount;
sf_write_short(myFile, data, count); sf_write_short(myFile, data, count);
data += count; data += count;
nbSamples -= count; sampleCount -= count;
} }
} }
} }

View File

@ -130,21 +130,21 @@ public :
/// \brief Read audio samples from the loaded sound /// \brief Read audio samples from the loaded sound
/// ///
/// \param data Pointer to the sample array to fill /// \param data Pointer to the sample array to fill
/// \param nbSamples Number of samples to read /// \param sampleCount Number of samples to read
/// ///
/// \return Number of samples actually read (may be less than \a nbSamples) /// \return Number of samples actually read (may be less than \a sampleCount)
/// ///
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
std::size_t Read(Int16* data, std::size_t nbSamples); std::size_t Read(Int16* data, std::size_t sampleCount);
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
/// \brief Write audio samples to the file /// \brief Write audio samples to the file
/// ///
/// \param data Pointer to the sample array to write /// \param data Pointer to the sample array to write
/// \param nbSamples Number of samples to write /// \param sampleCount Number of samples to write
/// ///
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
void Write(const Int16* data, std::size_t nbSamples); void Write(const Int16* data, std::size_t sampleCount);
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
/// \brief Change the current read position in the file /// \brief Change the current read position in the file
@ -200,7 +200,7 @@ private :
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
SNDFILE* myFile; ///< File descriptor SNDFILE* myFile; ///< File descriptor
Memory myMemory; ///< Memory reading info Memory myMemory; ///< Memory reading info
std::size_t myNbSamples; ///< Total number of samples in the file std::size_t mySampleCount; ///< Total number of samples in the file
unsigned int myChannelCount; ///< Number of channels used by the sound unsigned int myChannelCount; ///< Number of channels used by the sound
unsigned int mySampleRate; ///< Number of samples per second unsigned int mySampleRate; ///< Number of samples per second
}; };

View File

@ -298,7 +298,7 @@ bool SoundStream::FillAndPushBuffer(unsigned int bufferNum)
OnSeek(0); OnSeek(0);
// If we previously had no data, try to fill the buffer once again // If we previously had no data, try to fill the buffer once again
if (!data.Samples || (data.NbSamples == 0)) if (!data.Samples || (data.SampleCount == 0))
{ {
return FillAndPushBuffer(bufferNum); return FillAndPushBuffer(bufferNum);
} }
@ -311,12 +311,12 @@ bool SoundStream::FillAndPushBuffer(unsigned int bufferNum)
} }
// Fill the buffer if some data was returned // Fill the buffer if some data was returned
if (data.Samples && data.NbSamples) if (data.Samples && data.SampleCount)
{ {
unsigned int buffer = myBuffers[bufferNum]; unsigned int buffer = myBuffers[bufferNum];
// Fill the buffer // Fill the buffer
ALsizei size = static_cast<ALsizei>(data.NbSamples) * sizeof(Int16); ALsizei size = static_cast<ALsizei>(data.SampleCount) * sizeof(Int16);
ALCheck(alBufferData(buffer, myFormat, data.Samples, size, mySampleRate)); ALCheck(alBufferData(buffer, myFormat, data.Samples, size, mySampleRate));
// Push it into the sound queue // Push it into the sound queue