c/helos1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

runtime: disable interrupts on Printf

Browse Source 
Printf uses vsnprintf and a global buffer prone to race conditions.
This commit is contained in:
Edgaru089 2021-11-08 01:33:18 +08:00
parent ebbe907bb7
commit 9f86e52164
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
runtime/stdio.c
View File

@ -5,6 +5,7 @@
#include "../memory/memory.h" #include "../memory/memory.h"
#include "../graphics/graphics.h" #include "../graphics/graphics.h"
#include "../driver/irq/pic/serial/serial.h" #include "../driver/irq/pic/serial/serial.h"
#include "../interrupt/interrupt.h"
#include "../efimain.h" #include "../efimain.h"
#include <string.h> #include <string.h>
@ -92,6 +93,7 @@ void io_WriteConsoleASCII(const char *str) {
char __io_Printf_buffer[4096]; char __io_Printf_buffer[4096];
int io_Printf(const char *fmt, ...) { int io_Printf(const char *fmt, ...) {
INTERRUPT_DISABLE;
va_list args; va_list args;
va_start(args, fmt); va_start(args, fmt);
int ret = vsnprintf(__io_Printf_buffer, sizeof(__io_Printf_buffer), fmt, args); int ret = vsnprintf(__io_Printf_buffer, sizeof(__io_Printf_buffer), fmt, args);
@ -99,5 +101,6 @@ int io_Printf(const char *fmt, ...) {
io_WriteConsole(__io_Printf_buffer); io_WriteConsole(__io_Printf_buffer);
INTERRUPT_RESTORE;
return ret; return ret;
} }