mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2024-11-28 14:21:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Require that sf::WindowBase::handleEvents receives at least one argument

Browse Source
This commit is contained in:
Chris Thrasher 2024-07-21 10:46:09 -06:00
parent c8c8673259
commit 0831f055ce
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/SFML/Window/WindowBase.inl
View File

@ -57,6 +57,8 @@ struct DelayOverloadResolution
template <typename... Ts> template <typename... Ts>
void WindowBase::handleEvents(Ts&&... handlers) // NOLINT(cppcoreguidelines-missing-std-forward) void WindowBase::handleEvents(Ts&&... handlers) // NOLINT(cppcoreguidelines-missing-std-forward)
{ {
static_assert(sizeof...(Ts) > 0, "Must provide at least one handler");
// Disable misc-const-correctness for this line since clang-tidy // Disable misc-const-correctness for this line since clang-tidy
// complains about it even though the code would become uncompilable // complains about it even though the code would become uncompilable

3
test/Window/WindowBase.test.cpp
View File

@ -203,9 +203,6 @@ TEST_CASE("[Window] sf::WindowBase", runDisplayTests())
{ {
sf::WindowBase windowBase(sf::VideoMode({360, 240}), "WindowBase Tests"); sf::WindowBase windowBase(sf::VideoMode({360, 240}), "WindowBase Tests");
// Should compile if user provides nothing
windowBase.handleEvents();
// Should compile if user provides only a specific handler // Should compile if user provides only a specific handler
windowBase.handleEvents([](const sf::Event::Closed&) {}); windowBase.handleEvents([](const sf::Event::Closed&) {});