From 2d2e7fa5f499b6365d8318f45f8d01db1c89db0d Mon Sep 17 00:00:00 2001 From: Chris Thrasher Date: Thu, 7 Sep 2023 14:17:44 -0600 Subject: [PATCH] Disable warnings as errors by default --- .github/workflows/ci.yml | 2 +- cmake/CompilerWarnings.cmake | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d360e3c8f..30755fe3d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,7 +60,7 @@ jobs: - name: Configure CMake shell: bash - run: cmake -S $GITHUB_WORKSPACE -B $GITHUB_WORKSPACE/build -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install -DSFML_BUILD_EXAMPLES=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DSFML_BUILD_TEST_SUITE=TRUE ${{matrix.platform.flags}} ${{matrix.config.flags}} + run: cmake -S $GITHUB_WORKSPACE -B $GITHUB_WORKSPACE/build -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install -DSFML_BUILD_EXAMPLES=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DSFML_BUILD_TEST_SUITE=TRUE -DWARNINGS_AS_ERRORS=TRUE ${{matrix.platform.flags}} ${{matrix.config.flags}} - name: Build shell: bash diff --git a/cmake/CompilerWarnings.cmake b/cmake/CompilerWarnings.cmake index a26cc8f46..96231f8ce 100644 --- a/cmake/CompilerWarnings.cmake +++ b/cmake/CompilerWarnings.cmake @@ -4,7 +4,7 @@ # Helper function to enable compiler warnings for a specific set of files function(set_file_warnings) - option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" TRUE) + option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" FALSE) set(MSVC_WARNINGS /W4 # Baseline reasonable warnings