mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2025-02-22 22:36:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug conflating array element count with array size in bytes

Browse Source
This commit is contained in:
Chris Thrasher 2025-01-21 23:53:21 -07:00
parent 5f9c9fc4f8
commit 58a3abd433
No known key found for this signature in database
GPG Key ID: 56FB686C9DFC8E2C
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/Network/Packet.test.cpp
View File

@ -86,10 +86,10 @@ TEST_CASE("[Network] sf::Packet")
SECTION("Append and clear") SECTION("Append and clear")
{ {
sf::Packet packet; sf::Packet packet;
packet.append(data.data(), data.size()); packet.append(data.data(), sizeof(data));
CHECK(packet.getReadPosition() == 0); CHECK(packet.getReadPosition() == 0);
CHECK(packet.getData() != nullptr); CHECK(packet.getData() != nullptr);
CHECK(packet.getDataSize() == data.size()); CHECK(packet.getDataSize() == sizeof(data));
CHECK(!packet.endOfPacket()); CHECK(!packet.endOfPacket());
CHECK(bool{packet}); CHECK(bool{packet});
@ -275,17 +275,17 @@ TEST_CASE("[Network] sf::Packet")
CHECK(packet.onSend(size) == nullptr); CHECK(packet.onSend(size) == nullptr);
CHECK(size == 0); CHECK(size == 0);
packet.append(data.data(), data.size()); packet.append(data.data(), sizeof(data));
CHECK(packet.onSend(size) != nullptr); CHECK(packet.onSend(size) != nullptr);
CHECK(size == data.size()); CHECK(size == sizeof(data));
} }
SECTION("onReceive") SECTION("onReceive")
{ {
Packet packet; Packet packet;
packet.onReceive(data.data(), data.size()); packet.onReceive(data.data(), sizeof(data));
CHECK(packet.getReadPosition() == 0); CHECK(packet.getReadPosition() == 0);
CHECK(packet.getData() != nullptr); CHECK(packet.getData() != nullptr);
CHECK(packet.getDataSize() == data.size()); CHECK(packet.getDataSize() == sizeof(data));
} }
} }