From 739129d009cebb9e04ff184fc06c8508ba0be261 Mon Sep 17 00:00:00 2001 From: Chris Thrasher Date: Wed, 20 Sep 2023 17:28:30 -0600 Subject: [PATCH] Install Ninja in CI https://github.com/actions/runner-images/issues/8343#issuecomment-1727810519 Ninja's presence in the Windows images was due to it being a transitive dependency of another packages. It was never guaranteed to be present. The actions/runner-images devs do not plan on adding it so we're forced to install it ourselves. --- .github/workflows/ci.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7e3f64f41..1d7239043 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -110,14 +110,14 @@ jobs: # brew update brew install gcovr ninja || true - - name: Install OpenCppCoverage and add to PATH + - name: Install Windows Tools uses: nick-fields/retry@v2 - if: matrix.type.name == 'Debug' && runner.os == 'Windows' + if: runner.os == 'Windows' with: max_attempts: 10 timeout_minutes: 3 command: | - choco install OpenCppCoverage -y + choco install ninja OpenCppCoverage -y echo "C:\Program Files\OpenCppCoverage" >> $env:GITHUB_PATH - name: Configure CMake @@ -241,7 +241,9 @@ jobs: - name: Install Windows Dependencies if: runner.os == 'Windows' - run: curl.exe -o run-clang-tidy https://raw.githubusercontent.com/llvm/llvm-project/llvmorg-15.0.7/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py + run: | + choco install ninja + curl.exe -o run-clang-tidy https://raw.githubusercontent.com/llvm/llvm-project/llvmorg-15.0.7/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py - name: Install Linux Dependencies if: runner.os == 'Linux'