mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2024-11-28 14:21:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Protect against drawing a sprite when the underlying texture has been moved

Browse Source 
Inspired by #3062. If you construct a texture and a sprite then move the
sprite, the sprite is left pointing at an address where there is no
longer a usable texture. The texture's lifetime has not yet ended, however
the texture is in a moved-from state and thus it's not suitable to draw
the sprite. Doing so will result in unintended and undesirable effects.
This commit is contained in:
Chris Thrasher 2024-06-06 15:42:06 -06:00
parent 5484824948
commit 774fc2e65f
No known key found for this signature in database
GPG Key ID: 56FB686C9DFC8E2C
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/SFML/Graphics/Sprite.cpp
View File

@ -29,6 +29,7 @@
#include <SFML/Graphics/Sprite.hpp> #include <SFML/Graphics/Sprite.hpp>
#include <SFML/Graphics/Texture.hpp> #include <SFML/Graphics/Texture.hpp>
#include <cassert>
#include <cmath> #include <cmath>
#include <cstdlib> #include <cstdlib>
@ -128,6 +129,8 @@ FloatRect Sprite::getGlobalBounds() const
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
void Sprite::draw(RenderTarget& target, RenderStates states) const void Sprite::draw(RenderTarget& target, RenderStates states) const
{ {
assert(m_texture->getNativeHandle() != 0 && "Sprite::draw() Cannot draw sprite when texture is not initialized");
states.transform *= getTransform(); states.transform *= getTransform();
states.texture = m_texture; states.texture = m_texture;
states.coordinateType = CoordinateType::Pixels; states.coordinateType = CoordinateType::Pixels;