mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2025-02-08 01:18:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed potential buffer overflow in SoundFileReaderWav

Browse Source
This commit is contained in:
Laurent Gomila 2015-03-15 14:44:16 +01:00
parent 9d3024e13e
commit 81a8e4e4ca
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/SFML/Audio/SoundFileReaderWav.cpp
View File

@ -232,8 +232,7 @@ bool SoundFileReaderWav::parseHeader(Info& info)
// Skip potential extra information (should not exist for PCM) // Skip potential extra information (should not exist for PCM)
if (subChunkSize > 16) if (subChunkSize > 16)
{ {
char buffer[1024]; if (m_stream->seek(m_stream->tell() + subChunkSize - 16) == -1)
if (m_stream->read(buffer, subChunkSize - 16) != subChunkSize - 16)
return false; return false;
} }
} }
@ -252,8 +251,7 @@ bool SoundFileReaderWav::parseHeader(Info& info)
else else
{ {
// unknown chunk, skip it // unknown chunk, skip it
char buffer[1024]; if (m_stream->seek(m_stream->tell() + subChunkSize) == -1)
if (m_stream->read(buffer, subChunkSize) != subChunkSize)
return false; return false;
} }
} }