mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2024-11-28 22:31:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove Key::Last and Scan::Last enumerators

Browse Source 
The purpose of those was to make it obvious that an action is needed to
update KeyCount or ScancodeCount when adding more enumerators, but we
rarely touch those enumerations so it is not worth adding those
technical names to the public API.
This commit is contained in:
kimci86 2023-12-19 07:27:41 +01:00 committed by Lukas Dürrenberger
parent b13b488f9f
commit 82ee0f79ac
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/SFML/Window/Keyboard.hpp
View File

@ -152,8 +152,6 @@ enum Key
F14, //!< The F14 key F14, //!< The F14 key
F15, //!< The F15 key F15, //!< The F15 key
Pause, //!< The Pause key Pause, //!< The Pause key
Last = Pause, //!< Keep equal to last enumerator -- used to define KeyCount
}; };
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
@ -161,7 +159,7 @@ enum Key
/// ///
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
// NOLINTNEXTLINE(readability-identifier-naming) // NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int KeyCount{static_cast<unsigned int>(Key::Last) + 1}; static constexpr unsigned int KeyCount{static_cast<unsigned int>(Key::Pause) + 1};
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
/// \brief Scancodes /// \brief Scancodes
@ -326,8 +324,6 @@ enum class Scan
LaunchApplication2, //!< Keyboard Launch Application 2 key LaunchApplication2, //!< Keyboard Launch Application 2 key
LaunchMail, //!< Keyboard Launch Mail key LaunchMail, //!< Keyboard Launch Mail key
LaunchMediaSelect, //!< Keyboard Launch Media Select key LaunchMediaSelect, //!< Keyboard Launch Media Select key
Last = LaunchMediaSelect, //!< Keep equal to last enumerator -- used to define ScancodeCount
}; };
using Scancode = Scan; using Scancode = Scan;
@ -337,7 +333,7 @@ using Scancode = Scan;
/// ///
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
// NOLINTNEXTLINE(readability-identifier-naming) // NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int ScancodeCount{static_cast<unsigned int>(Scan::Last) + 1}; static constexpr unsigned int ScancodeCount{static_cast<unsigned int>(Scan::LaunchMediaSelect) + 1};
//////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////
/// \brief Check if a key is pressed /// \brief Check if a key is pressed