From cc3c748ab2947925355513904b9d390457405675 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20D=C3=BCrrenberger?= Date: Wed, 3 Oct 2018 22:02:16 +0200 Subject: [PATCH] Due to binary compatibility in a patch release the iOS fix needs to be reverted This reverts commit 08eb31e3272c5de25a40995856009dad822c0169. --- include/SFML/Graphics/RenderWindow.hpp | 7 ------- src/SFML/Graphics/RenderWindow.cpp | 18 ++++-------------- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/include/SFML/Graphics/RenderWindow.hpp b/include/SFML/Graphics/RenderWindow.hpp index 01f07828b..2b3b6bce4 100644 --- a/include/SFML/Graphics/RenderWindow.hpp +++ b/include/SFML/Graphics/RenderWindow.hpp @@ -177,13 +177,6 @@ protected: /// //////////////////////////////////////////////////////////// virtual void onResize(); - -private: - - //////////////////////////////////////////////////////////// - // Member data - //////////////////////////////////////////////////////////// - unsigned int m_defaultFrameBuffer; ///< Framebuffer to bind when targeting this window }; } // namespace sf diff --git a/src/SFML/Graphics/RenderWindow.cpp b/src/SFML/Graphics/RenderWindow.cpp index 42f4ffeaf..446e90609 100644 --- a/src/SFML/Graphics/RenderWindow.cpp +++ b/src/SFML/Graphics/RenderWindow.cpp @@ -34,16 +34,14 @@ namespace sf { //////////////////////////////////////////////////////////// -RenderWindow::RenderWindow() : -m_defaultFrameBuffer(0) +RenderWindow::RenderWindow() { // Nothing to do } //////////////////////////////////////////////////////////// -RenderWindow::RenderWindow(VideoMode mode, const String& title, Uint32 style, const ContextSettings& settings) : -m_defaultFrameBuffer(0) +RenderWindow::RenderWindow(VideoMode mode, const String& title, Uint32 style, const ContextSettings& settings) { // Don't call the base class constructor because it contains virtual function calls create(mode, title, style, settings); @@ -51,8 +49,7 @@ m_defaultFrameBuffer(0) //////////////////////////////////////////////////////////// -RenderWindow::RenderWindow(WindowHandle handle, const ContextSettings& settings) : -m_defaultFrameBuffer(0) +RenderWindow::RenderWindow(WindowHandle handle, const ContextSettings& settings) { // Don't call the base class constructor because it contains virtual function calls create(handle, settings); @@ -86,7 +83,7 @@ bool RenderWindow::setActive(bool active) // try to draw to the default framebuffer of the RenderWindow if (active && result && priv::RenderTextureImplFBO::isAvailable()) { - glCheck(GLEXT_glBindFramebuffer(GLEXT_GL_FRAMEBUFFER, m_defaultFrameBuffer)); + priv::RenderTextureImplFBO::unbind(); return true; } @@ -111,13 +108,6 @@ Image RenderWindow::capture() const //////////////////////////////////////////////////////////// void RenderWindow::onCreate() { - if (priv::RenderTextureImplFBO::isAvailable()) - { - // Retrieve the framebuffer ID we have to bind when targeting the window for rendering - // We assume that this window's context is still active at this point - glCheck(glGetIntegerv(GLEXT_GL_FRAMEBUFFER_BINDING, reinterpret_cast(&m_defaultFrameBuffer))); - } - // Just initialize the render target part RenderTarget::initialize(); }