Define default special member functions in headers

include/SFML/Audio/SoundRecorder.hpp

@@ -193,7 +193,7 @@ protected:
     /// This constructor is only meant to be called by derived classes.
     ///
     ////////////////////////////////////////////////////////////
-    SoundRecorder();
+    SoundRecorder() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Set the processing interval

include/SFML/Audio/SoundStream.hpp

@@ -192,7 +192,7 @@ protected:
     /// This constructor is only meant to be called by derived classes.
     ///
     ////////////////////////////////////////////////////////////
-    SoundStream();
+    SoundStream() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Define the audio stream parameters

include/SFML/Graphics/BlendMode.hpp

@@ -80,7 +80,7 @@ struct SFML_GRAPHICS_API BlendMode
     /// Constructs a blending mode that does alpha blending.
     ///
     ////////////////////////////////////////////////////////////
-    BlendMode();
+    BlendMode() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct the blend mode given the factors and equation.

include/SFML/Graphics/RenderStates.hpp

@@ -57,7 +57,7 @@ public:
     /// \li a null shader
     ///
     ////////////////////////////////////////////////////////////
-    RenderStates();
+    RenderStates() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct a default set of render states with a custom blend mode

include/SFML/Graphics/RenderWindow.hpp

@@ -52,7 +52,7 @@ public:
     /// use the other constructors or call create() to do so.
     ///
     ////////////////////////////////////////////////////////////
-    RenderWindow();
+    RenderWindow() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct a new window

include/SFML/Graphics/Shader.hpp

@@ -92,7 +92,7 @@ public:
     /// This constructor creates an invalid shader.
     ///
     ////////////////////////////////////////////////////////////
-    Shader();
+    Shader() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Destructor

include/SFML/Graphics/Transformable.hpp

@@ -47,13 +47,13 @@ public:
     /// \brief Default constructor
     ///
     ////////////////////////////////////////////////////////////
-    Transformable();
+    Transformable() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Virtual destructor
     ///
     ////////////////////////////////////////////////////////////
-    virtual ~Transformable();
+    virtual ~Transformable() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief set the position of the object

include/SFML/Graphics/VertexArray.hpp

@@ -52,7 +52,7 @@ public:
     /// Creates an empty vertex array.
     ///
     ////////////////////////////////////////////////////////////
-    VertexArray();
+    VertexArray() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct the vertex array with a type and an initial number of vertices

include/SFML/Graphics/VertexBuffer.hpp

@@ -72,7 +72,7 @@ public:
     /// Creates an empty vertex buffer.
     ///
     ////////////////////////////////////////////////////////////
-    VertexBuffer();
+    VertexBuffer() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct a VertexBuffer with a specific PrimitiveType

include/SFML/Network/Packet.hpp

@@ -56,37 +56,37 @@ public:
     /// Creates an empty packet.
     ///
     ////////////////////////////////////////////////////////////
-    Packet();
+    Packet() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Virtual destructor
     ///
     ////////////////////////////////////////////////////////////
-    virtual ~Packet();
+    virtual ~Packet() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Copy constructor
     ///
     ////////////////////////////////////////////////////////////
-    Packet(const Packet&);
+    Packet(const Packet&) = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Copy assignment
     ///
     ////////////////////////////////////////////////////////////
-    Packet& operator=(const Packet&);
+    Packet& operator=(const Packet&) = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Move constructor
     ///
     ////////////////////////////////////////////////////////////
-    Packet(Packet&&) noexcept;
+    Packet(Packet&&) noexcept = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Move assignment
     ///
     ////////////////////////////////////////////////////////////
-    Packet& operator=(Packet&&) noexcept;
+    Packet& operator=(Packet&&) noexcept = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Append data to the end of the packet

include/SFML/System/String.hpp

@@ -67,7 +67,7 @@ public:
     /// This constructor creates an empty string.
     ///
     ////////////////////////////////////////////////////////////
-    String();
+    String() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct from a single ANSI character and a locale

include/SFML/Window/VideoMode.hpp

@@ -49,7 +49,7 @@ public:
     /// This constructors initializes all members to 0.
     ///
     ////////////////////////////////////////////////////////////
-    VideoMode();
+    VideoMode() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Construct the video mode with its attributes

src/SFML/Audio/SoundRecorder.cpp

@@ -52,10 +52,6 @@ ALCdevice* captureDevice = nullptr;
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-SoundRecorder::SoundRecorder() = default;
-
-
 ////////////////////////////////////////////////////////////
 SoundRecorder::~SoundRecorder()
 {

src/SFML/Audio/SoundStream.cpp

@@ -47,10 +47,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-SoundStream::SoundStream() = default;
-
-
 ////////////////////////////////////////////////////////////
 SoundStream::~SoundStream()
 {

src/SFML/Graphics/BlendMode.cpp

@@ -46,10 +46,6 @@ const BlendMode BlendMax(BlendMode::One, BlendMode::One, BlendMode::Max);
 const BlendMode BlendNone(BlendMode::One, BlendMode::Zero, BlendMode::Add);
 
 
-////////////////////////////////////////////////////////////
-BlendMode::BlendMode() = default;
-
-
 ////////////////////////////////////////////////////////////
 BlendMode::BlendMode(Factor sourceFactor, Factor destinationFactor, Equation blendEquation) :
 colorSrcFactor(sourceFactor),

src/SFML/Graphics/RenderStates.cpp

@@ -44,10 +44,6 @@ const RenderStates RenderStates::Default(BlendMode(
     BlendMode::Add));
 
 
-////////////////////////////////////////////////////////////
-RenderStates::RenderStates() = default;
-
-
 ////////////////////////////////////////////////////////////
 RenderStates::RenderStates(const Transform& theTransform) : transform(theTransform)
 {

src/SFML/Graphics/RenderWindow.cpp

@@ -36,10 +36,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-RenderWindow::RenderWindow() = default;
-
-
 ////////////////////////////////////////////////////////////
 RenderWindow::RenderWindow(VideoMode mode, const String& title, std::uint32_t style, const ContextSettings& settings)
 {

src/SFML/Graphics/Shader.cpp

@@ -226,10 +226,6 @@ struct Shader::UniformBinder
 };
 
 
-////////////////////////////////////////////////////////////
-Shader::Shader() = default;
-
-
 ////////////////////////////////////////////////////////////
 Shader::~Shader()
 {
@@ -966,10 +962,6 @@ namespace sf
 Shader::CurrentTextureType Shader::CurrentTexture;
 
 
-////////////////////////////////////////////////////////////
-Shader::Shader() = default;
-
-
 ////////////////////////////////////////////////////////////
 Shader::~Shader() = default;
 

src/SFML/Graphics/Transformable.cpp

@@ -32,14 +32,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-Transformable::Transformable() = default;
-
-
-////////////////////////////////////////////////////////////
-Transformable::~Transformable() = default;
-
-
 ////////////////////////////////////////////////////////////
 void Transformable::setPosition(const Vector2f& position)
 {

src/SFML/Graphics/VertexArray.cpp

@@ -33,10 +33,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-VertexArray::VertexArray() = default;
-
-
 ////////////////////////////////////////////////////////////
 VertexArray::VertexArray(PrimitiveType type, std::size_t vertexCount) : m_vertices(vertexCount), m_primitiveType(type)
 {

src/SFML/Graphics/VertexBuffer.cpp

@@ -61,10 +61,6 @@ GLenum usageToGlEnum(sf::VertexBuffer::Usage usage)
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-VertexBuffer::VertexBuffer() = default;
-
-
 ////////////////////////////////////////////////////////////
 VertexBuffer::VertexBuffer(PrimitiveType type) : m_primitiveType(type)
 {

src/SFML/Network/Packet.cpp

@@ -37,30 +37,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-Packet::Packet() = default;
-
-
-////////////////////////////////////////////////////////////
-Packet::~Packet() = default;
-
-
-////////////////////////////////////////////////////////////
-Packet::Packet(const Packet&) = default;
-
-
-////////////////////////////////////////////////////////////
-Packet& Packet::operator=(const Packet&) = default;
-
-
-////////////////////////////////////////////////////////////
-Packet::Packet(Packet&&) noexcept = default;
-
-
-////////////////////////////////////////////////////////////
-Packet& Packet::operator=(Packet&&) noexcept = default;
-
-
 ////////////////////////////////////////////////////////////
 void Packet::append(const void* data, std::size_t sizeInBytes)
 {

src/SFML/System/Android/Activity.cpp

@@ -35,8 +35,6 @@
 
 #define LOGE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "sfml-error", __VA_ARGS__))
 
-LogcatStream::LogcatStream() = default;
-
 std::streambuf::int_type LogcatStream::overflow(std::streambuf::int_type c)
 {
     if (c == '\n')

src/SFML/System/Android/Activity.hpp

@@ -44,7 +44,7 @@
 class SFML_SYSTEM_API LogcatStream : public std::streambuf
 {
 public:
-    LogcatStream();
+    LogcatStream() = default;
 
     std::streambuf::int_type overflow(std::streambuf::int_type c) override;
 

src/SFML/System/String.cpp

@@ -37,10 +37,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-String::String() = default;
-
-
 ////////////////////////////////////////////////////////////
 String::String(char ansiChar, const std::locale& locale)
 {

src/SFML/Window/VideoMode.cpp

@@ -34,10 +34,6 @@
 
 namespace sf
 {
-////////////////////////////////////////////////////////////
-VideoMode::VideoMode() = default;
-
-
 ////////////////////////////////////////////////////////////
 VideoMode::VideoMode(const Vector2u& modeSize, unsigned int modeBitsPerPixel) :
 size(modeSize),

src/SFML/Window/macOS/CursorImpl.hpp

@@ -61,7 +61,7 @@ public:
     /// Refer to sf::Cursor::Cursor().
     ///
     ////////////////////////////////////////////////////////////
-    CursorImpl();
+    CursorImpl() = default;
 
     ////////////////////////////////////////////////////////////
     /// \brief Destructor

src/SFML/Window/macOS/CursorImpl.mm

@@ -49,11 +49,6 @@ NSCursor* loadFromSelector(SEL selector)
 
 namespace sf::priv
 {
-
-////////////////////////////////////////////////////////////
-CursorImpl::CursorImpl() = default;
-
-
 ////////////////////////////////////////////////////////////
 CursorImpl::~CursorImpl()
 {