mirrors/SFML
1
0
Fork 0
mirror of https://github.com/SFML/SFML.git synced 2025-01-31 13:45:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add tests for Unicode filenames with sf::Image #647

Browse Source
This commit is contained in:
FRex 2025-01-28 17:55:56 +01:00 committed by Chris Thrasher
parent 7c60447a39
commit f7e904172f
1 changed files with 39 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
test/Graphics/Image.test.cpp
View File

@ -265,6 +265,18 @@ TEST_CASE("[Graphics] sf::Image")
CHECK(!image.loadFromFile(".")); CHECK(!image.loadFromFile("."));
CHECK(!image.loadFromFile("this/does/not/exist.jpg")); CHECK(!image.loadFromFile("this/does/not/exist.jpg"));
// small n with tilde, from Spanish, outside of ASCII, inside common Latin 1 codepage
CHECK(!image.loadFromFile(std::filesystem::path(U"missing-file-\u00f1.png")));
// small n with acute accent, from Polish, outside of Latin 1 codepage
CHECK(!image.loadFromFile(std::filesystem::path(U"missing-file-\u0144.png")));
// CJK symbol for Sun, outside of any European language codepage
CHECK(!image.loadFromFile(std::filesystem::path(U"missing-file-\u65E5.png")));
// snail emoji, outside of Unicode Basic Multilingual Plane
CHECK(!image.loadFromFile(std::filesystem::path(U"missing-file-\U0001F40C.png")));
CHECK(image.getSize() == sf::Vector2u(0, 0)); CHECK(image.getSize() == sf::Vector2u(0, 0));
CHECK(image.getPixelsPtr() == nullptr); CHECK(image.getPixelsPtr() == nullptr);
} }
@ -410,23 +422,47 @@ TEST_CASE("[Graphics] sf::Image")
SECTION("To .bmp") SECTION("To .bmp")
{ {
filename /= "test.bmp"; filename /= "test.bmp";
CHECK(image.saveToFile(filename));
} }
SECTION("To .tga") SECTION("To .tga")
{ {
filename /= "test.tga"; filename /= "test.tga";
CHECK(image.saveToFile(filename));
} }
SECTION("To .png") SECTION("To .png")
{ {
filename /= "test.png"; filename /= "test.png";
CHECK(image.saveToFile(filename)); }
SECTION("To Spanish Latin1 filename .png")
{
// small n with tilde, from Spanish, outside of ASCII, inside common Latin 1 codepage
filename /= U"test-\u00f1.png";
}
SECTION("To Polish filename .png")
{
// small n with acute accent, from Polish, outside of Latin 1 codepage
filename /= U"test-\u0144.png";
}
SECTION("To Japanese CJK filename .png")
{
// CJK symbol for Sun, outside of any European language codepage
filename /= U"test-\u65E5.png";
}
SECTION("To emoji non-BMP Unicode filename .png")
{
// snail emoji, outside of Unicode Basic Multilingual Plane
filename /= U"test-\U0001F40C.png";
} }
// Cannot test JPEG encoding due to it triggering UB in stbiw__jpg_writeBits // Cannot test JPEG encoding due to it triggering UB in stbiw__jpg_writeBits
REQUIRE(image.saveToFile(filename));
REQUIRE(std::filesystem::exists(filename));
const sf::Image loadedImage(filename); const sf::Image loadedImage(filename);
CHECK(loadedImage.getSize() == sf::Vector2u(256, 256)); CHECK(loadedImage.getSize() == sf::Vector2u(256, 256));
CHECK(loadedImage.getPixelsPtr() != nullptr); CHECK(loadedImage.getPixelsPtr() != nullptr);