Addressed review comments
Fixed Vulkan.cpp clang-tidy issues
Used default-constructed objects instead of 0
More fun with OSX clang-tidy
Try casting a nullptr to see if clang-tidy can live with it
Revert "Try casting a nullptr to see if clang-tidy can live with it"
This reverts commit e217a1d8be45e3fd27dc73e1c7043be921d3830b.
Restored deleted line
CMake doesn't require absolute paths so we can safely remove
SRCROOT and let implicit relative pathing achieve the same result
with less work on our part.
Similar to sf::Time, sf::Angle provides a typesafe API for working
with angles and provides named functions for converting to and from
degrees and radians.
This removes the sfml- prefixed targets from the export set. The sfml-
prefixed targets are still available within the build tree but not to
downstream users thus making this an API breaking change when compared
to the 2.x releases. To keep things consistent, usage of the sfml-
targets were replaced with their namespaced counterparts.
This has a number of benefits:
1. It's more idiomatic. Modern CMake libraries are expected to
have namespaced targets.
2. Namespaced targets are less likely to collide with user-defined
targets. No one will accidentally define a SFML:: target.
3. If a namespaced target is not found by CMake, configuration
will immediately stop.
